Add reconciled single-path memo for the 5 collection fixes: ONE dev theme verified, ONE live push held on Steve's authenticated Preview

c85040c5084f23cf870b7e5f8dd1ae9ce36030b8 · 2026-06-23 16:25:44 -0700 · Steve

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Files touched

A pending-approval/collection-memos-RECONCILED.md

Diff

commit c85040c5084f23cf870b7e5f8dd1ae9ce36030b8
Author: Steve <steve@designerwallcoverings.com>
Date:   Tue Jun 23 16:25:44 2026 -0700

    Add reconciled single-path memo for the 5 collection fixes: ONE dev theme verified, ONE live push held on Steve's authenticated Preview
    
    Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 pending-approval/collection-memos-RECONCILED.md | 71 +++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/pending-approval/collection-memos-RECONCILED.md b/pending-approval/collection-memos-RECONCILED.md
new file mode 100644
index 00000000..c937cff0
--- /dev/null
+++ b/pending-approval/collection-memos-RECONCILED.md
@@ -0,0 +1,71 @@
+# RECONCILED: all 5 collection-page memos → ONE dev theme, ONE live push (DTD Option-A)
+
+**Owner:** vp-dw-commerce · **Drafted:** 2026-06-23 · **Status:** consolidated + staged + headless-verified on ONE dev theme; **LIVE push HELD on Steve's authenticated dev-Preview** (the one human-only gate every memo names).
+**Supersedes the individual "paste to push" sections of:** collection-toolbar-consolidation.md (A), collection-grid-toolbar-and-image-perf.md (B), collection-hero-duptitle-mobileheader.md (C, itself superseded by D), collection-rotating-newarrivals-hero.md (D), grid-js-init-abort-and-dev-build.md (E).
+
+---
+
+## Why this memo exists (the conflict I reconciled)
+
+The 5 memos were authored by 5 different dev sessions and split across **two dev themes**:
+- **A** staged on dev `143953264691`; **B/C/D/E** staged on dev `143947038771`.
+
+`sections/collection.liquid` is edited by BOTH **A** (removes native `#sort-by` + the dead `collection-grid-density.js` include) **and D** (adds `{% render 'dw-collection-hero-bg' %}` but RETAINS the native sort + density include). Each memo's own push script PUTs that file, so running both = **last-write-wins clobbers one set of fixes**. The other files don't collide (grid.js, header.liquid, product-list-item.liquid, and two separately-marked `custom.css` blocks).
+
+**DTD panel (Claude+Codex+Qwen, 2026-06-23) → Option A (2/1):** merge the colliding file, stage ALL fixes on ONE dev theme, re-verify, push once. (Claude dissented for "push non-colliding now, hold the merge" — absorbed, since A's mandatory re-verify step means the merge is never pushed unverified.)
+
+---
+
+## What I did (reversible, dev-only — DONE)
+
+1. **Merged `sections/collection.liquid`** = Memo A's version (toolbar cleanup: native `#sort-by` removed, `collection-grid-density.js` include removed, `collection-filters-horizontal` render kept) **+** Memo D's single `{% render 'dw-collection-hero-bg' %}` line. Diff-proven to be A + exactly the 3-line hero block, nothing else. 25/25 Liquid tag balance. Source: `shopify/collection-hero-fix/patched/sections_collection.MERGED.liquid`.
+2. **Consolidated ALL fixes onto the single dev theme `143947038771`** (backed up each overwritten asset to `shopify/collection-hero-fix/backups/consolidation-2026-06-23/`):
+   - pushed the merged `sections/collection.liquid`
+   - pushed Memo A's `snippets/collection-toolbar.liquid` (null-guard) + `layout/theme.liquid` (dup-slider removal + infinite-scroll scoping)
+   - (E's `grid.js`/`product-list-item`/`header`, D's `dw-collection-hero-bg` snippet + `dw-hero-rotator.js`, and BOTH custom.css blocks were already present on this theme)
+3. **Headless structural verification: 11/11 PASS** — hero render present, native sort-by gone, density.js include gone, toolbar include retained, toolbar null-guard present, dw-grid-control removed, inline density block removed, infinite-scroll scoped, both custom.css blocks present, grid.js is the 554KB production build, Liquid balanced.
+
+**Dev theme `143947038771` "★ 5.0 Grid+Infinite FIX (approve)" now carries EVERY fix from all 5 memos, merged, with no collision.**
+
+---
+
+## Why the LIVE push is HELD (not a failure — the gate)
+
+Every one of the 5 memos states the same hard limit: **anonymous `?preview_theme_id=` requests are served the LIVE theme's assets, not the dev theme's** (verified again here — both serve the same Boost client-rendered shell). So the runtime/visual behavior — Flickity engaging, hero crossfading, no blown full-width cards, single sort+density toolbar, mobile gap closed — can ONLY be confirmed via the **authenticated admin Preview button**, which is human-only. Pushing to the live customer-facing theme without that confirm would violate the stage-on-dev-then-VERIFY discipline (a wrong `collection.liquid` breaks the storefront). So I stopped at the verified-dev-consolidation and am handing Steve the single clean go.
+
+---
+
+## STEVE — verify once, then ONE command pushes everything
+
+### Verify (authenticated, ~2 min)
+Shopify admin → Online Store → Themes → **"★ 5.0 Grid+Infinite FIX (approve)" (143947038771)** → **Preview**. Open the homepage + `/collections/all` + `/collections/new-arrivals` + a vendor collection (e.g. `/collections/1838-wallcoverings`). Confirm:
+- **One** sort dropdown + **one** density slider + filter chips (no duplicate controls); density slider changes columns.
+- Hero band **crossfades through the newest products** every ~5s; **single** clean title (no grey pill, no dup).
+- Homepage carousels render as carousels (Flickity engages); **no** blown full-width product cards.
+- Mobile: cart + logo tight at top, no dead gap.
+- Console: `addEventListener`-null pageerror gone.
+
+Optional console probe on the Preview:
+```js
+({ toolbar: document.querySelectorAll('.collection-toolbar').length,
+   dupDensity: document.querySelectorAll('#dw-density-slider, #dw-col-range, .dw-gc').length,
+   nativeSort: document.querySelectorAll('#sort-by').length,
+   flickity: document.querySelectorAll('.flickity-enabled').length,
+   blown: [...document.querySelectorAll('.product-list-item img')].filter(i=>i.getBoundingClientRect().width>500).length })
+// WANT: toolbar 1, dupDensity 0, nativeSort 0, flickity > 0 (home), blown 0
+```
+
+### Push to LIVE — ONE command (replaces all 5 memos' push scripts)
+```
+! bash ~/Projects/Designer-Wallcoverings/shopify/collection-hero-fix/PUSH-LIVE-CONSOLIDATED.sh
+```
+It resolves `role==main` dynamically (currently `142250278963`), **backs up every overwritten live asset** to `shopify/collection-hero-fix/backups/live-push-<ts>/*.pushbak` BEFORE each PUT, PUTs the full consolidated set (grid.js + product-list-item + header + collection-toolbar + theme.liquid + merged collection.liquid + hero-bg snippet + hero-rotator.js + settings_schema hero group + both custom.css marked blocks), then re-verifies (10 structural checks + Liquid-error scan on 4 live collections).
+
+### After live is confirmed good (optional customizer + cleanup)
+- Customize → Theme settings → **Collection hero**: pick a default hero (~2000×600) and the "Rotate newest arrivals" toggle (default ON).
+- Set per-collection images over time (the HARD `every collection needs a bg hero` rule; the fix guarantees nothing looks broken meanwhile).
+- Delete the stale dev preview theme `143953264691` (Toolbar Consolidation Preview — its work is now folded into the merged file) and retire `143933472819` ("5.1" stale/partial).
+
+**Rollback (any time):** re-PUT every `*.pushbak` in the live-push backup dir to its original key.
+
+**$ cost:** $0 (all local + unmetered theme API to the unpublished dev theme). One DTD reconciliation panel: Codex $0.0036 + local Qwen (free) = **$0.004**.

← 82166919 Mark Designtex fill-in/UOM/archive memo DONE with execution · back to Designer Wallcoverings · Stage You-May-Also-Like mobile 2-up grid fix on dev theme 5. 1cd2c5df →