[object Object]

← back to Designer Wallcoverings

TK-11738: retire spent sample-variant backfill cron (scoped, un-does ff460585 re-arm)

d9e7b0e8f44b9f52c232d78f766ebde6ef33bf2e · 2026-09-17 11:36:39 -0700 · Steve

Scoped one-line disable of the writer on this branch so a checkout here cannot
re-materialize the accidental --apply re-arm (ff460585). NOT a revert of
ff460585 (tangled with TK-11241 versa-colorway work). See DTD verdict B.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TmvM611X4duoLdp1cFmpy2

Files touched

Diff

commit d9e7b0e8f44b9f52c232d78f766ebde6ef33bf2e
Author: Steve <steve@designerwallcoverings.com>
Date:   Thu Sep 17 11:36:39 2026 -0700

    TK-11738: retire spent sample-variant backfill cron (scoped, un-does ff460585 re-arm)
    
    Scoped one-line disable of the writer on this branch so a checkout here cannot
    re-materialize the accidental --apply re-arm (ff460585). NOT a revert of
    ff460585 (tangled with TK-11241 versa-colorway work). See DTD verdict B.
    
    Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_01TmvM611X4duoLdp1cFmpy2
---
 shopify/scripts/cron-create-sample-variants.sh | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/shopify/scripts/cron-create-sample-variants.sh b/shopify/scripts/cron-create-sample-variants.sh
index a3cf06bc..05d8b068 100755
--- a/shopify/scripts/cron-create-sample-variants.sh
+++ b/shopify/scripts/cron-create-sample-variants.sh
@@ -29,9 +29,20 @@ if [ -f "$PROGRESS_FILE" ]; then
 fi
 
 cd /root/Projects/Designer-Wallcoverings
-# --apply REQUIRED: as of 2026-09-14 create-missing-sample-variants.js is DRY BY DEFAULT
-# (dryRun = !args.includes('--apply')). Without --apply this cron would run dry, create zero
-# variants, exit 0, and its REMAINING>0 guard would never let it self-remove — a silent no-op.
-node "$SCRIPT" --apply >> "$LOG_FILE" 2>&1
+# ── RETIRED / DISABLED 2026-09-17 (TK-11738, DTD verdict B, re-confirmed verdict A) ──
+# This was a BOUNDED ONE-OFF backfill for 1,359 missing sample variants. It is SPENT:
+# sample-variant-creation-progress.json shows 1359/1359 complete (REMAINING=0), so the
+# self-remove guard above already retires the cron on its first tick. New SKUs get their
+# -Sample variant at import via cadence/cadence-import.js, so this writer is not needed.
+#
+# The writer line below is INTENTIONALLY DISABLED. Do NOT re-arm it on a schedule — the
+# "dry run looks like a silent no-op, so re-add --apply" reflex is exactly the accidental
+# ff460585 re-arm this ticket reverted, and an armed schedule would create junk sample
+# variants for any of the stale 1,359 audit SKUs since archived/discontinued.
+# If a genuinely NEW historical backfill is ever needed, run it ATTENDED with a fresh
+# audit + restore-map:   node "$SCRIPT" --apply
+#
+# node "$SCRIPT" --apply >> "$LOG_FILE" 2>&1   # <-- disabled: spent one-off, see above
+echo "cron-create-sample-variants: RETIRED (TK-11738) — no writer action taken." >> "$LOG_FILE"
 
-echo "=== $(date '+%Y-%m-%d %H:%M:%S PT') === Finished ===" >> "$LOG_FILE"
+echo "=== $(date '+%Y-%m-%d %H:%M:%S PT') === Finished (retired, no-op) ===" >> "$LOG_FILE"

← 0503f33e auto-data-snapshot: 2026-09-17T10:59:25 (3 data files) — sho  ·  back to Designer Wallcoverings  ·  auto-data-snapshot: 2026-09-17T12:05:07 (3 data files) — sho 0c9c07bb →