Revert "fix(skills): merge codex detection into setup contract"

79568409463cc6961c83abab96e91bf3168fc9a3 · 2026-03-30 19:49:45 -0700 · Matt Van Horn

This reverts commit 43d21f22d98cfb1914c93852a838919fcf1df64a.

Files touched

D docs/plans/2026-03-30-007-fix-codex-mode-detection-skipped-plan.md
M skills/printing-press/SKILL.md

Diff

commit 79568409463cc6961c83abab96e91bf3168fc9a3
Author: Matt Van Horn <mvanhorn@MacBook-Pro.local>
Date:   Mon Mar 30 19:49:45 2026 -0700

    Revert "fix(skills): merge codex detection into setup contract"
    
    This reverts commit 43d21f22d98cfb1914c93852a838919fcf1df64a.
---
 ...30-007-fix-codex-mode-detection-skipped-plan.md | 61 ----------------------
 skills/printing-press/SKILL.md                     | 11 ++--
 2 files changed, 8 insertions(+), 64 deletions(-)

diff --git a/docs/plans/2026-03-30-007-fix-codex-mode-detection-skipped-plan.md b/docs/plans/2026-03-30-007-fix-codex-mode-detection-skipped-plan.md
deleted file mode 100644
index fc756294..00000000
--- a/docs/plans/2026-03-30-007-fix-codex-mode-detection-skipped-plan.md
+++ /dev/null
@@ -1,61 +0,0 @@
----
-title: "fix: Codex mode detection skipped during skill execution"
-type: fix
-status: active
-date: 2026-03-30
----
-
-# fix: Codex mode detection skipped during skill execution
-
-## Overview
-
-Merge the Codex Mode Detection bash block into the Setup Contract so both run as a single mandatory block. Currently they're separate sections and the LLM skips the second one.
-
-## Problem Frame
-
-When running `/printing-press Redfin Codex`, the skill executor ran the setup contract (binary check, version, directories) but skipped the Codex Mode Detection block entirely. It jumped straight to Phase 0 without checking for the `codex` keyword. The user noticed mid-run that codex delegation never activated.
-
-Root cause: the setup contract ends at line 151 (`PRESS_SETUP_CONTRACT_END`), then a new `### Codex Mode Detection` section starts at line 153 with its own bash block. The LLM treats these as two separate steps and skips the second one when eager to start Phase 0. There's no enforcement that forces both blocks to execute.
-
-## Requirements Trace
-
-- R1. Codex detection must run every time the setup contract runs - not as a separate optional step
-- R2. The `CODEX_MODE` variable and circuit breaker state must be initialized before Phase 0 begins
-
-## Scope Boundaries
-
-- Only modifying `skills/printing-press/SKILL.md`
-- Not changing codex delegation behavior, just ensuring detection actually runs
-- Not changing the setup contract's other functionality
-
-## Key Technical Decisions
-
-- **Merge into one bash block**: Move the codex detection code inside the setup contract's `PRESS_SETUP_CONTRACT_START`/`END` markers. One block = one execution. Rationale: LLMs reliably execute single code blocks marked "before doing anything else." They skip secondary blocks that look optional.
-- **Keep the `### Codex Mode Detection` heading as prose**: Move it above the merged block as explanatory text, not a separate section with its own code block.
-
-## Implementation Units
-
-- [ ] **Unit 1: Merge codex detection into setup contract**
-
-  **Goal:** Make codex detection impossible to skip by merging it into the single mandatory setup block.
-
-  **Requirements:** R1, R2
-
-  **Files:**
-  - Modify: `skills/printing-press/SKILL.md`
-
-  **Approach:**
-  - Move the codex detection bash code (lines 157-184) into the setup contract bash block (before line 150, after `mkdir -p`)
-  - Remove the separate `### Codex Mode Detection` section header
-  - Remove the `CODEX_DETECTION_START`/`END` HTML markers (no longer needed as a separate block)
-  - Keep the `PRESS_SETUP_CONTRACT_START`/`END` markers wrapping everything
-  - Add a comment in the merged block like `# --- Codex mode detection ---` for readability
-
-  **Patterns to follow:**
-  - The setup contract already has inline comments for each section (binary check, scope derivation, directory creation)
-
-  **Verification:**
-  - Single bash block between `PRESS_SETUP_CONTRACT_START` and `PRESS_SETUP_CONTRACT_END`
-  - No separate codex detection bash block exists
-  - `CODEX_MODE` and `CODEX_CONSECUTIVE_FAILURES` are initialized in the merged block
-  - The text after the block still references version checking and run-scoped paths as before
diff --git a/skills/printing-press/SKILL.md b/skills/printing-press/SKILL.md
index c4704781..6ed1e4dd 100644
--- a/skills/printing-press/SKILL.md
+++ b/skills/printing-press/SKILL.md
@@ -147,8 +147,13 @@ PRESS_MANUSCRIPTS="$PRESS_HOME/manuscripts"
 PRESS_CURRENT="$PRESS_RUNSTATE/current"
 
 mkdir -p "$PRESS_RUNSTATE" "$PRESS_LIBRARY" "$PRESS_MANUSCRIPTS" "$PRESS_CURRENT"
+```
+<!-- PRESS_SETUP_CONTRACT_END -->
+
+### Codex Mode Detection
 
-# --- Codex mode detection (must run as part of setup, not a separate step) ---
+<!-- CODEX_DETECTION_START -->
+```bash
 # Codex mode: opt-in only. User must pass "codex" or "--codex" to enable.
 if echo "$ARGUMENTS" | grep -qiE '(^| )(--?codex|codex)( |$)'; then
   CODEX_MODE=true
@@ -169,7 +174,7 @@ if [ "$CODEX_MODE" = "true" ]; then
     CODEX_MODEL=$(codex config get model 2>/dev/null || echo "gpt-5.4")
     echo "Codex mode enabled (model: $CODEX_MODEL). Code-writing tasks will be delegated to Codex."
   else
-    echo "Codex CLI not found - running in standard mode."
+    echo "Codex CLI not found — running in standard mode."
     CODEX_MODE=false
   fi
 fi
@@ -177,7 +182,7 @@ fi
 # Circuit breaker state
 CODEX_CONSECUTIVE_FAILURES=0
 ```
-<!-- PRESS_SETUP_CONTRACT_END -->
+<!-- CODEX_DETECTION_END -->
 
 After running the setup contract, check binary version compatibility. Read the `min-binary-version` field from this skill's YAML frontmatter. Run `printing-press version --json` and parse the version from the output. Compare it to `min-binary-version` using semver rules. If the installed binary is older than the minimum, warn the user: "printing-press binary vX.Y.Z is older than the minimum required vA.B.C. Run `go install github.com/mvanhorn/cli-printing-press/cmd/printing-press@latest` to update." Continue anyway but surface the warning prominently.

← 43d21f22 fix(skills): merge codex detection into setup contract · back to Cli Printing Press · fix(skills): merge codex detection into setup contract (#84) 14b9e74f →