[object Object]

← back to Cli Printing Press

fix(ci): remove redundant generated compile work (#361)

a5ba1b4a4721477b1524dc2cb891848be23e8642 · 2026-04-28 01:03:37 -0700 · Trevin Chow

Files touched

Diff

commit a5ba1b4a4721477b1524dc2cb891848be23e8642
Author: Trevin Chow <trevin@trevinchow.com>
Date:   Tue Apr 28 01:03:37 2026 -0700

    fix(ci): remove redundant generated compile work (#361)
---
 .github/workflows/lint.yml                   | 2 +-
 internal/generator/generator_test.go         | 8 --------
 internal/generator/session_handshake_test.go | 3 ---
 internal/openapi/parser_test.go              | 7 -------
 4 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index fc474f92..34274d1a 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -155,7 +155,7 @@ jobs:
         run: |
           set -o pipefail
 
-          generated_compile_tests='^(TestGenerateProjectsCompile|TestGenerateCliutilPackage|TestGenerateFreshnessHelperEmitted|TestGenerateShareEmittedWhenEnabled|TestGenerateAgentContextCommand|TestGenerateBrowserChromeH3Transport|TestGenerateHTMLExtractionEndpoint|TestGenerateHTMLExtractionEmbeddedJSONMode|TestGenerateHTMLExtractionPerModeGating|TestGenerateStoreWithBatchResourceDoesNotDuplicateUpsertBatch|TestGenerateStoreUpsertBatchDispatchesToTypedTable|TestGenerateStoreBackfillsIndexedColumnsOnUpgrade|TestGenerateStoreQuotesNumericTableAndDerivedIdentifiers|TestGeneratedOutput_PromotedCommandCompiles|TestGeneratedHelpers_AuthWithKeyURL_Compiles|TestGenerate_CookieAuthUsesBrowserTemplate|TestGenerate_ComposedAuthUsesBrowserTemplate|TestJSONStringParamRejectsInvalidValueBeforeClient|TestGenerateGraphQLBFFUsesSemanticCommandSurface|TestGenerateWhichFallsBackToCommandTree|TestGenerateDependentSyncCompiles|TestGenerateDependentSyncReservedWordCompiles|TestGeneratedSyncTreatsAccessDeniedAsWarning|TestGenerateGraphQLCompiles|TestGenerateMCPCodeOrchestrationEmitsSearchExecute|TestGenerateMCPIntentsEmittedWhenDeclared|TestGenerateMCPEndpointToolsHiddenSuppressesEndpointTools|TestGenerateMCPMainRemoteRuntime|TestGenerateMCPMainRemoteCompiles|TestSessionHandshakeBrowserTransportSharesJar|TestGenerateFromOpenAPICompiles)$'
+          generated_compile_tests='^(TestGenerateProjectsCompile|TestGenerateCliutilPackage|TestGenerateFreshnessHelperEmitted|TestGenerateShareEmittedWhenEnabled|TestGenerateAgentContextCommand|TestGenerateBrowserChromeH3Transport|TestGenerateHTMLExtractionEndpoint|TestGenerateHTMLExtractionEmbeddedJSONMode|TestGenerateHTMLExtractionPerModeGating|TestGenerateStoreWithBatchResourceDoesNotDuplicateUpsertBatch|TestGenerateStoreUpsertBatchDispatchesToTypedTable|TestGenerateStoreBackfillsIndexedColumnsOnUpgrade|TestGenerateStoreQuotesNumericTableAndDerivedIdentifiers|TestGeneratedOutput_PromotedCommandCompiles|TestGeneratedHelpers_AuthWithKeyURL_Compiles|TestGenerate_CookieAuthUsesBrowserTemplate|TestGenerate_ComposedAuthUsesBrowserTemplate|TestJSONStringParamRejectsInvalidValueBeforeClient|TestGenerateGraphQLBFFUsesSemanticCommandSurface|TestGenerateWhichFallsBackToCommandTree|TestGenerateDependentSyncCompiles|TestGenerateDependentSyncReservedWordCompiles|TestGeneratedSyncTreatsAccessDeniedAsWarning|TestGenerateGraphQLCompiles|TestGenerateMCPCodeOrchestrationEmitsSearchExecute|TestGenerateMCPIntentsEmittedWhenDeclared|TestGenerateMCPEndpointToolsHiddenSuppressesEndpointTools|TestGenerateMCPMainRemoteRuntime|TestGenerateMCPMainRemoteCompiles|TestGenerateFromOpenAPICompiles)$'
 
           go test -json -timeout 12m -run "$generated_compile_tests" ./internal/generator ./internal/openapi 2>&1 | tee /tmp/go-test-generated.json
           status=${PIPESTATUS[0]}
diff --git a/internal/generator/generator_test.go b/internal/generator/generator_test.go
index caedcf60..40cbe0da 100644
--- a/internal/generator/generator_test.go
+++ b/internal/generator/generator_test.go
@@ -95,14 +95,6 @@ func TestGenerateProjectsCompile(t *testing.T) {
 
 			runGoCommand(t, outputDir, "mod", "tidy")
 			runGoCommand(t, outputDir, "build", "./...")
-
-			binaryPath := filepath.Join(outputDir, naming.CLI(apiSpec.Name))
-			runGoCommand(t, outputDir, "build", "-o", binaryPath, "./cmd/"+naming.CLI(apiSpec.Name))
-
-			info, err := os.Stat(binaryPath)
-			require.NoError(t, err)
-			require.False(t, info.IsDir())
-			require.NotZero(t, info.Size())
 		})
 	}
 }
diff --git a/internal/generator/session_handshake_test.go b/internal/generator/session_handshake_test.go
index a3c881fc..a4ffe8a5 100644
--- a/internal/generator/session_handshake_test.go
+++ b/internal/generator/session_handshake_test.go
@@ -167,9 +167,6 @@ func TestSessionHandshakeBrowserTransportSharesJar(t *testing.T) {
 	if !strings.Contains(string(sessionContent), "func (m *SessionManager) CookieJar() http.CookieJar") {
 		t.Error("session.go missing CookieJar accessor")
 	}
-
-	runGoCommand(t, dir, "mod", "tidy")
-	runGoCommand(t, dir, "build", "./...")
 }
 
 // TestSessionHandshakeNotEmittedForOtherAuth verifies the session helper is
diff --git a/internal/openapi/parser_test.go b/internal/openapi/parser_test.go
index 707309b9..28f28486 100644
--- a/internal/openapi/parser_test.go
+++ b/internal/openapi/parser_test.go
@@ -197,13 +197,6 @@ func TestGenerateFromOpenAPICompiles(t *testing.T) {
 
 			runGo(t, outputDir, "mod", "tidy")
 			runGo(t, outputDir, "build", "./...")
-
-			binaryPath := filepath.Join(outputDir, naming.CLI(parsed.Name))
-			runGo(t, outputDir, "build", "-o", binaryPath, "./cmd/"+naming.CLI(parsed.Name))
-
-			info, err := os.Stat(binaryPath)
-			require.NoError(t, err)
-			require.NotZero(t, info.Size())
 		})
 	}
 }

← ddacddba fix(ci): speed up generated compile tests and caches (#360)  ·  back to Cli Printing Press  ·  fix(ci): shard test lanes (#362) 95cf6c88 →