ADMIN_PASS resolvable from on-host secrets (DW_SIGNUP_ADMIN_PASS) so a strong per-host admin password can be set without a wire leak; public /admin must not stay on DW2024! at go-live

21d567f71491b32a5b2bfda26148724749d6ec35 · 2026-07-28 15:29:42 -0700 · Steve Abrams

Files touched

M lib/config.js

Diff

commit 21d567f71491b32a5b2bfda26148724749d6ec35
Author: Steve Abrams <steve@designerwallcoverings.com>
Date:   Tue Jul 28 15:29:42 2026 -0700

    ADMIN_PASS resolvable from on-host secrets (DW_SIGNUP_ADMIN_PASS) so a strong per-host admin password can be set without a wire leak; public /admin must not stay on DW2024! at go-live
---
 lib/config.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/config.js b/lib/config.js
index 6db47d9..3d10f13 100644
--- a/lib/config.js
+++ b/lib/config.js
@@ -79,9 +79,12 @@ const config = {
   GEORGE_EXTERNAL_SEND_TOKEN: firstEnv('GEORGE_EXTERNAL_SEND_TOKEN', GEORGE_ENVS),
   GEORGE_BASIC_AUTH: firstEnv('GEORGE_BASIC_AUTH', GEORGE_ENVS) || 'admin:',
 
-  // Admin review surface basic-auth (Steve's fleet standard).
-  ADMIN_USER: process.env.ADMIN_USER || 'admin',
-  ADMIN_PASS: process.env.ADMIN_PASS || 'DW2024!',
+  // Admin review surface basic-auth. Resolve order: explicit env → on-host secrets
+  // master → the fleet default. Reading from the secrets file lets a strong per-host
+  // ADMIN_PASS be provisioned WITHOUT passing the value on a command line (no wire leak)
+  // — the public /admin/trade surface must not stay on the documented DW2024! at go-live.
+  ADMIN_USER: process.env.ADMIN_USER || firstEnv('ADMIN_USER', SECRETS_ENVS) || 'admin',
+  ADMIN_PASS: process.env.ADMIN_PASS || firstEnv('DW_SIGNUP_ADMIN_PASS', SECRETS_ENVS) || 'DW2024!',
 
   // --- Trade-application notify + one-click email approval ---
   // Every new /trade/apply emails a review card (via George) to this office inbox

← e723240 chore: lint safe-fixes (redact gift code in logs, esc gift c · back to Dw Signup Fulfillment · fix(theme): point trade-apply modal at canonical signup.desi 848697f →