todo for layer-independent parameters in get_allow_patterns

b43d30563defe07659eba66c5dcdcbee1a943f5a · 2025-11-27 19:26:02 +0000 · Alex Cheema

Files touched

M src/exo/worker/download/huggingface_utils.py

Diff

commit b43d30563defe07659eba66c5dcdcbee1a943f5a
Author: Alex Cheema <alexcheema123@gmail.com>
Date:   Thu Nov 27 19:26:02 2025 +0000

    todo for layer-independent parameters in get_allow_patterns
---
 src/exo/worker/download/huggingface_utils.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/exo/worker/download/huggingface_utils.py b/src/exo/worker/download/huggingface_utils.py
index cde32a48..1f85ff1c 100644
--- a/src/exo/worker/download/huggingface_utils.py
+++ b/src/exo/worker/download/huggingface_utils.py
@@ -105,6 +105,9 @@ def get_allow_patterns(weight_map: dict[str, str], shard: ShardMetadata) -> list
             ):
                 shard_specific_patterns.add(filename)
         sorted_file_names = sorted(weight_map.values())
+        # TODO: if the model needs any "layer-independent" parameters,
+        # we might want to always add files that correspond to them
+        # e.g. lm_head
         if shard.is_first_layer:
             shard_specific_patterns.add(sorted_file_names[0])
         elif shard.is_last_layer:

← 20d73e90 fix dashboard case sensitive model id · back to Exo · add aarch64-linux for the spark 93f699b6 →