Homes on Spec: correct stale README claims that misled a downstream review (TK-10387)

2726cf3511ca21e96501e75abb9732a4f1bc4b41 · 2026-09-04 05:59:47 -0700 · Steve

Item 4 said the EAS projectId was still the SET-AT-EAS-INIT placeholder. It is not —
app.json has carried a real projectId for some time. That stale line is what led an
earlier review pass to conclude push registration could never fire, which inverted the
actual finding: registration DOES succeed, so getExpoPushTokenAsync was handing a
device identifier to Expo for an Alerts feature that cannot deliver anything.

Item 1 now describes the PUSH_BACKEND_READY gate and states the flip must happen in
the same change that wires the backend. Item 5 marked done — /privacy returns 200,
verified today.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QfGYEoLBywwJD1nfrHe1on

Files touched

M apps/mobile/README.md

Diff

commit 2726cf3511ca21e96501e75abb9732a4f1bc4b41
Author: Steve <steve@designerwallcoverings.com>
Date:   Fri Sep 4 05:59:47 2026 -0700

    Homes on Spec: correct stale README claims that misled a downstream review (TK-10387)
    
    Item 4 said the EAS projectId was still the SET-AT-EAS-INIT placeholder. It is not —
    app.json has carried a real projectId for some time. That stale line is what led an
    earlier review pass to conclude push registration could never fire, which inverted the
    actual finding: registration DOES succeed, so getExpoPushTokenAsync was handing a
    device identifier to Expo for an Alerts feature that cannot deliver anything.
    
    Item 1 now describes the PUSH_BACKEND_READY gate and states the flip must happen in
    the same change that wires the backend. Item 5 marked done — /privacy returns 200,
    verified today.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    Claude-Session: https://claude.ai/code/session_01QfGYEoLBywwJD1nfrHe1on
---
 apps/mobile/README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/apps/mobile/README.md b/apps/mobile/README.md
index 90ccee36..0237491c 100644
--- a/apps/mobile/README.md
+++ b/apps/mobile/README.md
@@ -120,9 +120,9 @@ npx eas-cli submit --platform ios --profile production --latest
 
 ### Known TODOs / Wiring Needed
 
-1. **Push backend endpoint** — `lib/notifications.ts` registers a token but does not POST it to any server. Wire to `https://homesonspec.com/api/push/register` when that endpoint exists.
+1. **Push backend endpoint** — `lib/notifications.ts` requests notification permission but deliberately does NOT mint a push token while `PUSH_BACKEND_READY` is `false`, because `getExpoPushTokenAsync()` transmits a device identifier to Expo and nothing can send a push yet. Wire `https://homesonspec.com/api/push/register`, uncomment the POST, and flip `PUSH_BACKEND_READY` to `true` **in the same change** (TK-10387).
 2. **Map tap → native Save** — the Map tab's detail sheet shows a "View Details" button that deep-links via `Linking.openURL`. A future improvement: also offer "Save this Home" from the map callout (needs the same save bridge as the Browse tab).
 3. **Real app icon + splash** — placeholder blue PNGs must be replaced before App Review.
-4. **EAS projectId** — `SET-AT-EAS-INIT` placeholder in `app.json` and `lib/notifications.ts` must be updated after `eas init`.
-5. **Privacy page** — `https://homesonspec.com/privacy` must exist before App Review.
+4. ~~**EAS projectId**~~ — DONE. `app.json` carries the real projectId (`9d110d60-…`); `lib/notifications.ts` reads it from `expoConfig.extra.eas.projectId`. The `SET-AT-EAS-INIT` placeholder survives only in `finish-homesonspec-appstore.sh` as a guard. This line previously said otherwise and caused a downstream review to wrongly conclude push registration could never fire.
+5. ~~**Privacy page**~~ — DONE. `https://homesonspec.com/privacy` returns 200 (verified 2026-09-04).
 6. **Browse save bridge accuracy** — the JS injected into the WebView reads `h1` + `data-price` / `data-location` attributes for save metadata. These selectors should be verified against the live PDP markup and tightened if needed.

← d98894aa Homes on Spec: route every WebView through one hardened Trac · back to Homesonspec · auto-data-snapshot: 2026-09-04T06:32:13 (1 data files) — app 16d8e5af →