← back to Raffiawalls
step2 vendor-leak fix: dual-key /sample resolver + handle_display hrefs
28063a2cf1fad9e705223e98173556f733738afc · 2026-06-09 13:47:48 -0700 · Steve
Files touched
M public/index.htmlM server.js
Diff
commit 28063a2cf1fad9e705223e98173556f733738afc
Author: Steve <steve@designerwallcoverings.com>
Date: Tue Jun 9 13:47:48 2026 -0700
step2 vendor-leak fix: dual-key /sample resolver + handle_display hrefs
---
public/index.html | 10 +++++-----
server.js | 35 ++++++++++++++++++++++++++++++++++-
2 files changed, 39 insertions(+), 6 deletions(-)
diff --git a/public/index.html b/public/index.html
index 03d9a21..6003a9d 100644
--- a/public/index.html
+++ b/public/index.html
@@ -673,9 +673,9 @@ function cardHTML(p) {
return '<img loading="' + (eager ? 'eager' : 'lazy') + '"' + (eager ? ' fetchpriority="high"' : '') + ' src="' + escAttr(safeImg(p.image_url)) + '" alt="' + escAttr(p.title) + '">'
+ '<div class="overlay">'
+ '<div class="pat">' + escAttr(p.pattern_name || p.title) + '</div>'
- + '<div class="ven">Designer Wallcoverings · ' + escAttr(p.sku || p.handle || '') + '</div>'
+ + '<div class="ven">Designer Wallcoverings · ' + escAttr(p.sku || p.handle_display || p.handle || '') + '</div>'
+ '<div class="actions">'
- + '<button class="sample-btn" onclick="event.stopPropagation();dwmOpen(\'Sample\',' + JSON.stringify({sku:p.sku||p.handle, title:p.title, image_url:safeImg(p.image_url)}).replace(/"/g,'"') + ')">Sample</button>'
+ + '<button class="sample-btn" onclick="event.stopPropagation();dwmOpen(\'Sample\',' + JSON.stringify({sku:p.sku||p.handle_display||p.handle, title:p.title, image_url:safeImg(p.image_url)}).replace(/"/g,'"') + ')">Sample</button>'
+ '</div></div>';
}
@@ -687,7 +687,7 @@ function rowHTML(p) {
const aes = LABELS[p.aesthetic] || p.aesthetic || '—';
return '<img loading="lazy" src="' + escAttr(safeImg(p.image_url)) + '" alt="' + escAttr(p.title) + '">'
+ '<div class="r-pat">' + escAttr(p.pattern_name || p.title) + '</div>'
- + '<div class="r-col r-sku">' + escAttr(p.sku || p.handle || '—') + '</div>'
+ + '<div class="r-col r-sku">' + escAttr(p.sku || p.handle_display || p.handle || '—') + '</div>'
+ '<div class="r-col r-aes">' + escAttr(String(aes).replace(/-/g, ' ')) + '</div>'
+ '<div class="r-col r-price">' + price + '</div>';
}
@@ -697,7 +697,7 @@ function rowHTML(p) {
// chips, and CTAs for sample + Big Red chat. The modal NEVER reveals vendor.
function openDetails(p) {
const safeP = {
- sku: p.sku || p.handle || '',
+ sku: p.sku || p.handle_display || p.handle || '',
title: p.title || '',
pattern: p.pattern_name || p.title || '',
image_url: safeImg(p.image_url),
@@ -1304,7 +1304,7 @@ async function renderRailSections(){
const curated = items.filter((_, i) => i % 5 === 3).slice(0, 12);
function card(p) {
const url = (p.image_url || '').replace(/(_\d+x\d*)(\.(jpg|jpeg|png|webp|gif))(\?|$)/i, '$2$4');
- return '<a class="rail-card" href="/sample/' + encodeURIComponent(p.handle || p.sku) + '">' +
+ return '<a class="rail-card" href="/sample/' + encodeURIComponent(p.handle_display || p.handle || p.sku) + '">' +
'<img src="' + url + '" alt="' + (p.title || '').replace(/"/g, '"') + '" loading="lazy">' +
'<div class="rc-title">' + ((p.title || '').split('|')[0] || '').trim() + '</div>' +
'<div class="rc-meta">Designer Wallcoverings</div>' +
diff --git a/server.js b/server.js
index 6a09787..7a46190 100644
--- a/server.js
+++ b/server.js
@@ -212,8 +212,40 @@ app.get('/api/facets', (req, res) => {
app.get('/api/health', (req, res) => res.json({ status: 'ok', count: PRODUCTS.length, dropped: DROPPED }));
+// Step 2 of the vendor handle/sku text-leak fix (2026-06-09): the client's
+// /sample/ hrefs now point at the vendor-scrubbed `handle_display` slug
+// (emitted by _shared/api-vendor-redact since Step 1), so the raw vendor-bearing
+// handle never rides in the URL bar. This route is DUAL-KEY — it resolves the raw
+// handle/sku FIRST (old bookmarks + buy path, byte-identical behavior), then falls
+// back to a redacted->product map built after catalog load. If two raw handles
+// redact to the same display slug, that slug is logged and left raw-only.
+const { redactVendorText } = require('../_shared/vendor-text-redact');
+let SAMPLE_DISPLAY = new Map(); // redacted display slug -> product
+function buildSampleDisplayMap() {
+ const map = new Map();
+ const collided = new Set();
+ for (const p of PRODUCTS) {
+ for (const key of [p.handle, p.sku]) {
+ if (!key) continue;
+ const d = redactVendorText(String(key));
+ if (!d || d === key) continue; // nothing redacted — raw route already matches
+ const prev = map.get(d);
+ if (prev && prev !== p) { collided.add(d); continue; }
+ map.set(d, p);
+ }
+ }
+ for (const d of collided) {
+ map.delete(d);
+ console.warn(`[raffiawalls] /sample display-slug collision — keeping raw-only for "${d}"`);
+ }
+ SAMPLE_DISPLAY = map;
+ console.log(`[raffiawalls] /sample dual-key map: ${map.size} display slugs, ${collided.size} collisions (raw-only)`);
+}
+
app.get('/sample/:handle', (req, res) => {
- const p = PRODUCTS.find(x => x.handle === req.params.handle || x.sku === req.params.handle);
+ const key = req.params.handle;
+ const p = PRODUCTS.find(x => x.handle === key || x.sku === key) // raw first — old behavior intact
+ || SAMPLE_DISPLAY.get(key); // then the redacted display form
if (!p) return res.status(404).send('Not found');
res.redirect(302, p.product_url || `${DW_SHOPIFY}/products/${encodeURIComponent(p.handle)}#sample`);
});
@@ -281,6 +313,7 @@ app.use((req, res) => {
console.log(`[${__SITE}] loaded ${PRODUCTS.length} from data/products.json (static mode)`);
} catch (_) { PRODUCTS = []; }
}
+ buildSampleDisplayMap(); // Step 2: redacted->raw /sample resolver keys
app.listen(PORT, '127.0.0.1', () => {
console.log(`raffiawalls listening on http://127.0.0.1:${PORT}`);
});
← ab4d4e6 Scrub residual vendor names from products.json (title/vendor
·
back to Raffiawalls
·
raffiawalls: rails fire again — wire sliders + grid filter t c362dca →