`verification/e2e-proof.json`

89 lines
{
  "schema_version": 1,
  "ticket": "TK-11399-stayclaim-arcgis-feature-query-errors-si",
  "correlation_id": "cycle1650-cJ8lZ4-TK11399",
  "receipt_dm": "M-02741",
  "timestamp": "2026-09-10T16:59:33.951398+00:00",
  "intent": "Reject ArcGIS feature-query errors and malformed page/features containers before reporting a successful import; retain valid empty success and pool cleanup.",
  "risk_tier": "R1 isolated code; external and database boundaries fully substituted",
  "environment": "macstudio3; actual TypeScript script entrypoint run through Node stripTypeScriptTypes and VM; no real pg driver or network available in test context",
  "baseline": {
    "commit": "3881fa9f9a44020a4f1d86905a9132b9e7986956",
    "worktree": "clean before owned edits",
    "defect": "HTTP 200 ArcGIS error treated as empty success",
    "regression_before_fix": {
      "passed": 16,
      "failed": 11,
      "artifact": "/Users/macstudio3/Projects/ticket-system/data/codex-yoloforever/cycle-20260910T1650Z.cJ8lZ4/child-tests-red.tap"
    }
  },
  "build_identity": {
    "sha256": {
      "scripts/ingest-la-historic-monuments.ts": "f3b10c4b7e98fd66fa96c02a4165af0782b9de099b006077248140d7e5ccc153",
      "scripts/tests/ingest-la-historic-monuments.test.cjs": "68394678d1866d502e2dd292b2aabdd8a90182f111a5c968070b287756c746c4"
    }
  },
  "commands": [
    "node --test scripts/tests/ingest-la-historic-monuments.test.cjs",
    "git diff --check"
  ],
  "checks": [
    {
      "name": "Actual script entrypoint targeted suite",
      "verdict": "PASS",
      "passed": 27,
      "failed": 0,
      "artifact": "verification/hcm-feature-query-tests.txt"
    },
    {
      "name": "HTTP 200 ArcGIS error with and without features",
      "verdict": "PASS",
      "detail": "exit 1, diagnostic with offset, zero SQL, pool.end once, no final success"
    },
    {
      "name": "Null/array/string page, absent/null/object/string features",
      "verdict": "PASS",
      "detail": "fail closed before SQL, exit 1, pool.end once, no final success"
    },
    {
      "name": "Valid empty page",
      "verdict": "PASS",
      "detail": "exit 0, zero SQL, final zero-row success, pool.end once"
    },
    {
      "name": "Normal row",
      "verdict": "PASS",
      "detail": "listing lookup/create and designation insert argument assertions; exit 0; one-row success; pool closed"
    },
    {
      "name": "ArcGIS or malformed page after 1000 successful rows",
      "verdict": "PASS",
      "detail": "offsets 0 and 1000, 3000 simulated SQL operations before failure, exit 1, pool.end once, no final success"
    },
    {
      "name": "Metadata/preflight and DB failure regressions",
      "verdict": "PASS",
      "detail": "existing 15 tests preserved; DB failure also suppresses final success"
    },
    {
      "name": "Diff whitespace",
      "verdict": "PASS"
    },
    {
      "name": "Live ingestion / production persisted-state checks",
      "verdict": "SKIP",
      "reason": "Explicitly outside authorized local fix; no real network/DB calls or writes allowed. No production readiness claim."
    }
  ],
  "negative_checks": "ArcGIS error takes precedence even alongside valid empty features; malformed null page no longer hidden by test fixture fallback.",
  "cleanup": "No real external state created. VM state discarded; logs retained. Prior layer proof preserved in verification/hcm-layer-identity-e2e-proof.json.",
  "rollback": "Revert the scoped local commit if necessary; do not reset unrelated work.",
  "limitations": [
    "Earlier valid pages may remain persisted after a later failure; atomic import/rollback remains out of scope.",
    "Feature field validation, transaction semantics and full live ingestion remain unchanged."
  ],
  "verdict": "PASS for local feature-query failure handling; parent independent acceptance pending",
  "approval_required": "Any live ingestion, database writes, deployment or schedule installation remains gated.",
  "parent_acceptance": "pending parent CLI proof, Cody, final DTD"
}