← back to Wholivedthere

CHANGES.md

20 lines

## Applied
- `scripts/deploy-direct.sh:21` — removed hardcoded GoDaddy credential fallbacks and now reads `GODADDY_API_KEY` / `GODADDY_API_SECRET` from the environment only — prevents exposed source defaults from being used.
- `scripts/deploy-direct.sh:24` — added a fail-fast check when GoDaddy credentials are missing — avoids running DNS updates with empty credentials.
- `scripts/deploy-pastdoor.sh:28` — removed hardcoded GoDaddy credential fallbacks and now reads `GODADDY_API_KEY` / `GODADDY_API_SECRET` from the environment only — prevents exposed source defaults from being used.
- `scripts/deploy-pastdoor.sh:32` — added a fail-fast check when GoDaddy credentials are missing — avoids running DNS/registrar steps with empty credentials.
- `.env.example:3` — added placeholder-only entries for DPLA, GoDaddy, and Cloudflare variables — documents required env vars without copying real secrets.

## Deferred (needs Steve)
- P0 — `.env:2` — real Google/DPLA/GoDaddy secrets are present according to the review — left `.env` untouched and credential rotation needs account access.
- P0 — `scripts/deploy-direct.sh:65` — deploy script drops the `pastdoor` database — destructive database workflow is outside the safe fix list and needs an owner-approved deployment design.
- P0 — `mcp-la-records/src/arcgis.mjs:83` — ArcGIS `where` query interpolates user input — query semantics and validation rules need product-aware handling.
- P0 — `mcp-la-records/src/arcgis.mjs:97` — unvalidated `limit` reaches ArcGIS result count — API behavior change was not in the approved safe list.
- P0 — `scripts/schema.sql:58` — generated column uses `now()` — SQL/schema changes are explicitly out of scope.
- P1 — `mcp-la-records/src/arcgis.mjs:39` — fetch has no timeout — network behavior change was not in the approved safe list.
- P1 — `mcp-la-records/src/arcgis.mjs:99` — address lookup swallows upstream failures — API error semantics change was not in the approved safe list.
- P1 — `mcp-la-records/src/index.mjs:69` — MCP handler lacks runtime `args` validation — validation contract change was not in the approved safe list.
- P1 — `scripts/deploy-pastdoor.sh:60` — rsync does not exclude `.env*` — deploy behavior change was not one of the allowed safe fix categories.
- P1 — `scripts/smoke-test.sh:65` — smoke test accepts API `404` responses — test expectation change was not in the approved safe list.
- P1 — `PLAN.md:1` / `INTEGRATION.md:1` — docs disagree on architecture — documentation rewrite was not requested for safe fixes.